test(NODE-7065): unskip langchainjs tests #89
Merged
+15
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
durran
changed the title
baileympearson
requested changes
Aug 1, 2025
| @@ -37,7 +37,11 @@ setup_langchain_integration() { | |||
|
|
|||
| yarn add --dev jest-junit | |||
| export JEST_JUNIT_OUTPUT_NAME=results.xml | |||
|
|
|||
| # Trim trailing slashes since lanchainjs is doing string manipulationn, not | |||
There was a problem hiding this comment.
What trailing slashes are we talking about here? Should the secrets just be updated to not have trailing slashes instead?
There was a problem hiding this comment.
The trailing "/" in the URL from the secrets. I don't really think we should change the secret itself. Rather I'd say the ideal thing would be for langchain to update their generation of the Azure endpoint to use the URL class and not straight string manipulation.
baileympearson
approved these changes
Aug 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on langchain-ai/langchainjs#8588. Will change back to main repo after that merges.